Open
Conversation
Contributor
Author
|
This is currently rebased on top of #444, but I'll rebase it properly later and remove the draft. |
Ph4ntomas
force-pushed
the
fix-surface-closing-event
branch
from
fb94ca7 to
956533e
Compare
Contributor
Author
|
This works well, but I wonder if I should expand on the lua side of things. As far as I can tell, the widget stream is kept open indefinitely. OTOH, this is ready to go, so maybe looking into that can be pushed to a later date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason I assumed widget event stream would closed when the associated sender is droped.
Since it's not the case, we need to send the closing event when the surface is dropped by server.